Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ZVM): Add ZVM segment and docs #5990

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ggottemo
Copy link

Prerequisites

  • [ x ] I have read and understood the contributing guide.
  • [ x ] The commit message follows the conventional commits guidelines.
  • [ x ] Tests for the changes have been added (for bug fixes / features).
  • [ x ] Docs have been added/updated (for bug fixes / features).

Description

Added a segment for ZVM (Zig Version Manager), that displays the version currently 'in use', similar to NVM (Node Version Manager) in the JavaScript ecosystem.

src/segments/zvm.go Show resolved Hide resolved
src/segments/zvm.go Show resolved Hide resolved
Changed behavior to turn off colors for zvm when finding the version
@ggottemo
Copy link
Author

Apologies if you already get a notification, wasn't sure if I needed to click 'Re-request review' again or not

valid bool
}

func (c *colorCommand) detectColorState() colorState {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary? That switch should not reset the entire command output for following commands, right? If so, this is terrible design on their part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants